Separate local from imported metadata properties for ScannedResources #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
force-pushed
the
issues-331-jrgriffiniii-improve-metadata-display
branch
3 times, most recently
from
7fc2da3
to
4303165
Compare
jrgriffiniii
changed the title
escowles
reviewed
Oct 20, 2017
| # @param attribute_names [Symbol] | ||
| def self.suppress(attribute_names) | ||
| attribute_names = Array.wrap(attribute_names) | ||
| attribute_names.each { |attribute_name| self.displayed_attributes.delete(attribute_name) } |
There was a problem hiding this comment.
I think several of these could be shortened, e.g. couldn't this be:
self.displayed_attributes -= Array.wrap(attribute_names)
escowles
reviewed
Oct 20, 2017
| @@ -0,0 +1,28 @@ | |||
| <div id="attributes"> | |||
There was a problem hiding this comment.
Can we avoid some of these duplicate views? Could we make one of them _resource_attributes_default.html.erb? Could we have one copy and then have this view and the other one call out to it with render partial ?
|
I like the general approach here, and think this is a big improvement on making the logic for what to display clearer. I left a couple of comments around streamlining a couple of things. |
…tes; Separating imported metadata attributes from local attributes within the ScannedResource and ScannedMap Decorators
…ucturing the view templates to use a partial for imported attributes
jrgriffiniii
force-pushed
the
issues-331-jrgriffiniii-improve-metadata-display
branch
from
4303165
to
885d2bd
Compare
jrgriffiniii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #331