Set visibility based on Date Created #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return unless date | ||
| Time.zone.parse(date) | ||
| rescue | ||
| Rails.logger.debug("Unable to parse created date: #{change_set.resource.primary_imported_metadata.created}") |
There was a problem hiding this comment.
Is debug normally used for these types of errors, or would warn be needed? (I'm uncertain as to whether or not the logging level might affect this).
There was a problem hiding this comment.
Switched it to warn.
hackartisan
reviewed
Dec 28, 2017
| @@ -623,4 +623,55 @@ | |||
| expect(solr_record["member_of_ssim"]).to eq ["id-#{parent.id}"] | |||
| end | |||
| end | |||
|
|
|||
| context "setting visibility from remote metadata" do | |||
There was a problem hiding this comment.
Add a test for the case where it's not checked?
hackartisan
reviewed
Dec 28, 2017
|
|
||
| def calculated_rights_statement | ||
| if public_access? | ||
| "http://rightsstatements.org/vocab/NKC/1.0/" |
There was a problem hiding this comment.
We're using this as a default somewhere else, too. At what point to we consider loading these into constants? Perhaps a new ticket.
tpendragon
force-pushed
the
set_visibility_automatically
branch
from
10e96ad
to
caccdb5
Compare
hackartisan
approved these changes
Dec 28, 2017
jrgriffiniii
approved these changes
Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #691.
This adds a new checkbox to automatically set visibility/rights statement based on what the date of the object is. The checkbox looks like this: