Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fixity dashboard viewable only by admins #907

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Make fixity dashboard viewable only by admins #907

merged 1 commit into from
Mar 14, 2018

Conversation

hackartisan
Copy link
Member

fixes #899

tpendragon
tpendragon requested changes Mar 13, 2018
View reviewed changes
app/views/catalog/_fixity_dashboard_home.html.erb Outdated
<ul>
<li><%= link_to 'Fixity Dashboard', fixity_dashboard_path %></li>
</ul>
<% if current_or_guest_user.admin? %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just do <% if can?(:read, :fixity) %>?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we get a spec for viewing the link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah totally. I put that in the controller after restricting the view. will change it to use can?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec added. ready for re-review.

@tpendragon
Copy link
Contributor

@HackMasterA You said you had failing feature specs, but CI looks happy - I'll let you hit the button if it's a local issue.

@hackartisan
Copy link
Member Author

my problem was due to mismatch in versions between chrome browser and chromedriver. this fixed it https://github.com/flavorjones/chromedriver-helper#updating-to-latest-chromedriver

@hackartisan hackartisan merged commit b0c6c36 into master Mar 14, 2018
@hackartisan hackartisan deleted the fixity-access branch March 14, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpendragon tpendragon tpendragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access controls for fixity dashboard
2 participants
@hackartisan @tpendragon