This repository has been archived by the owner on May 14, 2022. It is now read-only.
Spawn a background export job when a new export is created #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpstroop
reviewed
Jan 24, 2017
| @@ -37,7 +38,7 @@ def set_export | |||
| # Only allow a trusted parameter "white list" through. | |||
| def export_params | |||
| params.require(:export).permit(:pid, :job, :status, :last_error, :last_success, :logfile, | |||
| :page) | |||
| :page, :ark) | |||
There was a problem hiding this comment.
Will ARKs work as the unique key (I assume that's what this is for)? If we plan to export before the object is finished in some cases (didn't we?) If we don't mint an ARK until the object is "finished"...
There was a problem hiding this comment.
We're passing the ARK here so it can get passed to the export job and added to the Bag metadata. We use the pid as the unique key for retrieving the object from Fedora.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.