Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds search feature for non-exact match #144

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Adds search feature for non-exact match #144

merged 2 commits into from
Sep 8, 2023

Conversation

leefaisonr
Copy link
Contributor

@leefaisonr leefaisonr commented Sep 7, 2023 •
edited
Loading

Ref #22

Acceptance criteria to complete PR

  • refactor so that the database query logic is in models rather than controllers
  • that variable exact_match is just called match for less confusion because sometimes it is an exact match and sometimes it is the closest result
  • "Aarons" is not hard-coded into the query.

@leefaisonr @sandbergja
Adds search feature for non-exact match
9574e94 
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@leefaisonr @hackartisan
Finished non-matching-search function
7ea1284 
Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
@leefaisonr leefaisonr marked this pull request as ready for review September 8, 2023 13:55
@bess
Copy link
Contributor

bess commented Sep 8, 2023

😍

@bess bess merged commit 8ad7ebe into main Sep 8, 2023
4 checks passed
@bess bess deleted the non-matching-search branch September 8, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandbergja sandbergja sandbergja left review comments

@bess bess bess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leefaisonr @bess @sandbergja