Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gc index pagination #68

Closed
wants to merge 5 commits into from
Closed

Gc index pagination #68

wants to merge 5 commits into from

Conversation

leefaisonr
Copy link
Contributor

No description provided.

leefaisonr and others added 2 commits April 25, 2023 15:28
@leefaisonr
add Kaminari gem
ac4cc7a
@leefaisonr @hackartisan
Add pagenation for GuideCard index page
a95e0ec 
Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
hackartisan
hackartisan requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and it works. Needs a system test to visit and page and check that pagenation is there. And needs styling, not sure whether/how that's provided by the gem or if we should try to pull it from somewhere else.

leefaisonr and others added 2 commits April 26, 2023 10:25
@leefaisonr
rubocop update
6e85a98
@leefaisonr @bess
adds pagination for GuideCard index
db20e5c 
Co-authored-by: Bess Sadler <bess@users.noreply.github.com>
@leefaisonr
Copy link
Contributor Author

Superseded by #70

@leefaisonr leefaisonr closed this May 5, 2023
@leefaisonr leefaisonr deleted the gc-index-pagination branch June 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leefaisonr @hackartisan