Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid subject values within PlumJsonldConverter #188

Open
jrgriffiniii opened this issue Oct 24, 2017 · 2 comments
Open

Handle invalid subject values within PlumJsonldConverter #188

jrgriffiniii opened this issue Oct 24, 2017 · 2 comments

Comments

@jrgriffiniii
Copy link
Contributor

For cases where subject values are string literals (and are expected to be URI's to vocabulary term resources), log a warning during the indexing process.

@hackartisan
Copy link
Member

Did this happen with real data or just in testing? I've noticed a lot of strings used in testing in figgy at least.

@escowles
Copy link
Member

I wouldn't be surprised if there are some strings lurking in the LAE data. But even if not, I think it's good to make this code more robust and flexible, instead of depending on the LAE ephemera configuration to guarantee that we're only going to see IDs in the subject field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants