Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

link to holding location and sort based on code #45

Merged
merged 1 commit into from
Dec 17, 2015
Merged

link to holding location and sort based on code #45

merged 1 commit into from
Dec 17, 2015

Conversation

tampakis
Copy link
Contributor

Closes #41.

@jpstroop
Copy link
Member

Why did the coverage drop so much?

@tampakis
Copy link
Contributor Author

That's odd - it decided to include all of the engine-related files in the coverage this time. Can we configure coverage to ignore the files?
lib/locations/version.rb, lib/locations/engine.rb, lib/locations.rb, lib/generators/locations/install_generator.rb

The install_generator clearly works if the specs are able to run...

@escowles
Copy link
Member

@tampakis: you can add filters to exclude stuff. See https://github.com/pulibrary/plum/blob/master/spec/spec_helper.rb

@tampakis
Copy link
Contributor Author

Thanks @escowles! Back to 100%

jpstroop pushed a commit that referenced this pull request Dec 17, 2015
Merge pull request #45 from pulibrary/holding_sort
35ecec1 
link to holding location and sort based on code
@jpstroop jpstroop merged commit 35ecec1 into development Dec 17, 2015
@jpstroop jpstroop deleted the holding_sort branch December 17, 2015 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tampakis @jpstroop @escowles