Adding digital location attribute and route to view only digital locations - closes #46 #47
Conversation
| class AddDigitalLocationToDeliveryLocation < ActiveRecord::Migration | ||
| def change | ||
| add_column :locations_delivery_locations, :digital_location, :boolean | ||
| end |
There was a problem hiding this comment.
Should we have the migration set true or false for existing locations, or would be better/easier to do this in the console later?
There was a problem hiding this comment.
Setting a default seems like a good idea, to minimize the manual editing required -- should be it be true?
There was a problem hiding this comment.
If we just want a default, true is fine and then manually editing to get things into a correct state.
As I said in the original issue,
Locations::DeliveryLocation.select { |d| d.pickup_location? }gets us really close; only two ("Lewis Library, Geosciences and Map Library" and "ReCAP Reading Rooom") would be incorrect; so if getting more fancy seems appropriate, that might be an idea.
There was a problem hiding this comment.
I don't know about setting a default value that's another column. So I've added a second migration that updates everything in the db.
|
👍 wanna squash? |
escowles
force-pushed
the
digital_location
branch
from
bafa903
to
98faa5f
Compare
Adding digital location attribute and route to view only digital locations - closes #46
No description provided.