Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

WIP - DO NOT MERGE! #54

Closed
wants to merge 12 commits into from
Closed

WIP - DO NOT MERGE! #54

wants to merge 12 commits into from

Conversation

sdellis
Copy link
Member

@sdellis sdellis commented Jun 13, 2016

Covers Issue #53

@coveralls
Copy link

coveralls commented Jun 13, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-5.2%) to 94.841% when pulling 7d29029 on issue-53 into c0ef9f8 on development.

kevinreiss
kevinreiss reviewed Jun 13, 2016
View reviewed changes
app/controllers/locations/floors_controller.rb

# GET /floors/new
def new
@floor = Floor.new(floor_params)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you need the Floor.new(floor_params) here, just Floor.new should suffice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I added that after reading up, but it had no affect on the test results

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-4.8%) to 95.238% when pulling 17d7ded on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-4.8%) to 95.238% when pulling 2ece830 on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-3.1%) to 96.863% when pulling f55e5f6 on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-3.1%) to 96.863% when pulling 2cd4fc9 on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-3.1%) to 96.875% when pulling a4d5b91 on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.7%) to 97.255% when pulling d51470a on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 99.216% when pulling da7defd on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling fc158e8 on issue-53 into c0ef9f8 on development.

@coveralls
Copy link

coveralls commented Jun 15, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e9b8bb7 on issue-53 into c0ef9f8 on development.

@sdellis sdellis closed this Jun 15, 2016
@sdellis sdellis deleted the issue-53 branch June 15, 2016 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdellis @coveralls @kevinreiss @tampakis