Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Adds image uploader to Floors #60

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Adds image uploader to Floors #60

merged 1 commit into from
Jun 21, 2016

Conversation

sdellis
Copy link
Member

@sdellis sdellis commented Jun 21, 2016

Need assistance setting up carrierwave tests.

@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c2e37ff on issue-58 into 9cdb41c on development.

@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9d0d702 on issue-58 into 9cdb41c on development.

@sdellis sdellis changed the title WIP - DO NOT MERGE!!! Adds image uploader to Floors Jun 21, 2016
@sdellis
Copy link
Member Author

sdellis commented Jun 21, 2016

@tampakis I believe I've squashed these commits correctly. Ready for merge.

@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 11ca205 on issue-58 into 9cdb41c on development.

tampakis
tampakis reviewed Jun 21, 2016
View reviewed changes
spec/models/locations/floor_spec.rb
describe FloorplanUploader do
include CarrierWave::Test::Matchers

#let(:floor) { double('floor') }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line.

@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 79bb223 on issue-58 into 9cdb41c on development.

@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling baa8e54 on issue-58 into 9cdb41c on development.

@coveralls
Copy link

coveralls commented Jun 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling baa8e54 on issue-58 into 9cdb41c on development.

@tampakis tampakis merged commit ee5c092 into development Jun 21, 2016
@tampakis tampakis deleted the issue-58 branch June 21, 2016 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdellis @coveralls @tampakis