Skip to content

Commit

Permalink
Remove unused method
Browse files Browse the repository at this point in the history
  • Loading branch information
sandbergja committed May 8, 2023
1 parent 586b7ed commit 85f21bd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions app/services/holding_requests_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ def doc_id
@document.fetch('id')
end

# Retrieve the host id(s) for the constituent record
# @return <Array>
def host_id
@document.fetch('contained_in_s', [])
end

# Access the holding locations from Bib. Data
# @return [Hash] location hash structure
delegate :holding_locations, to: :@bib_data_service
Expand Down
5 changes: 0 additions & 5 deletions spec/services/physical_holdings_markup_builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
allow(adapter).to receive(:alma_holding?).and_return(true)
allow(adapter).to receive(:doc_electronic_access).and_return('http://arks.princeton.edu/ark:/88435/dsp0141687h654': ['DataSpace', 'Citation only'])
allow(adapter).to receive(:unavailable_holding?).and_return(false)
allow(adapter).to receive(:host_id).and_return([])
allow(adapter).to receive(:sc_location_with_suppressed_button?).with(holding).and_return(false)
end

Expand Down Expand Up @@ -203,7 +202,6 @@
before do
allow(adapter).to receive(:alma_holding?).and_return(false)
allow(adapter).to receive(:document).and_return(document)
allow(adapter).to receive(:host_id).and_return(["coin-3750"])
allow(holding).to receive(:dig).and_return("coin-3750")
end
# this should be hitting the third condition, but does not seem to be
Expand Down Expand Up @@ -268,7 +266,6 @@

before do
allow(adapter).to receive(:document).and_return(document)
allow(adapter).to receive(:host_id).and_return(["SCSB-6593031"])
allow(holding).to receive(:dig).and_return("SCSB-6593031")
end

Expand Down Expand Up @@ -333,7 +330,6 @@

before do
allow(adapter).to receive(:document).and_return(document)
allow(adapter).to receive(:host_id).and_return(["SCSB-10422725"])
allow(holding).to receive(:dig).and_return("SCSB-10422725")
end

Expand Down Expand Up @@ -389,7 +385,6 @@
end
before do
allow(adapter).to receive(:document).and_return(document)
allow(adapter).to receive(:host_id).and_return(["99125038613506421"])
allow(holding).to receive(:dig).and_return("99125038613506421")
end
it 'generates the request link for the host record' do
Expand Down

0 comments on commit 85f21bd

Please sign in to comment.