Move Alma and Standard Numbers to their own modules

Remove commented out code

app/models/concerns/blacklight/solr/document/marc.rb

@@ -95,24 +95,6 @@ def to_ctx(format)
           @_ctx || build_ctx(format)
         end
 
-        # returns true if doc originated from alma
-        def alma_record?
-          if /^[0-9]+/.match?(self['id'])
-            true
-          else
-            false
-          end
-        end
-
-        # does we have any standard numbers that can be used by other services
-        def standard_numbers?
-          std_numbers.any? { |v| key? v }
-        end
-
-        def std_numbers
-          %w[lccn_s isbn_s issn_s oclc_s]
-        end
-
         def format_to_openurl_genre(format)
           return 'book' if format == 'book'
           return 'bookitem' if format == 'book'

app/models/requests/solr_open_url_context.rb

@@ -24,15 +24,6 @@ def openurl_ctx_kev
       ctx.kev
     end
 
-    ## double check what are valid openURL formsts in the catatlog
-    ## look at our choices and map
-    # def format_to_openurl_genre(format)
-    #   return 'book' if format == 'book'
-    #   return 'journal' if format == 'serial'
-    #   return 'journal' if format == 'journal'
-    #   'unknown'
-    # end
-
     private
 
       def build_ctx

app/models/solr_document.rb

@@ -3,6 +3,8 @@
 class SolrDocument
   include Blacklight::Solr::Document
   include Orangelight::Document::Export
+  include SolrDocument::Alma
+  include SolrDocument::StandardNumbers
 
   # Explicitly required for sneakers
   include Blacklight::Document::Extensions

app/models/solr_document/alma.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+class SolrDocument
+  # Special alma functionality for SolrDocument
+  module Alma
+    def alma_record?
+      /^[0-9]+/.match?(self['id'])
+    end
+  end
+end

app/models/solr_document/standard_numbers.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+class SolrDocument
+  # Standard Numbers functionality for SolrDocument
+  module StandardNumbers
+    def standard_numbers?
+      standard_number_fields.any? { |field| key? field }
+    end
+
+    private
+
+      def standard_number_fields
+        %w[lccn_s isbn_s issn_s oclc_s]
+      end
+  end
+end