i3338 non-search param deprecation (blacklight deprecations, part 2) #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
changed the title
sandbergja
force-pushed
the
i3338-non-search-param
branch
from
6103f29
to
b2e70b3
Compare
christinach
requested changes
Jan 4, 2023
There was a problem hiding this comment.
@sandbergja I noticed a padding issue in the Publication date facet, where the range limit is. Can you please check?
The new release fixes the search_state_fields deprecation warning
sandbergja
force-pushed
the
i3338-non-search-param
branch
from
8f9a531
to
11ba58e
Compare
|
@christinach Thanks for catching this! Can you re-review? |
carolyncole
added a commit
to pulibrary/pdc_discovery
that referenced
this pull request
Jan 30, 2023
Cribbing from @sandbergja work [here](pulibrary/orangelight#3339)
bess
pushed a commit
to pulibrary/pdc_discovery
that referenced
this pull request
Jan 31, 2023
* Upgrading to blacklight 7.33 On the way to 8.0 * Updating config.search_state_fields in Blacklight Cribbing from @sandbergja work [here](pulibrary/orangelight#3339) * Removing render_search_bar in favor of Blacklight::SearchBarComponent Cribbing from @sandbergja work pulibrary/orangelight@330671e * Adding a to the search parameters It can be a part of the parameters on the error page * Removing BlacklightRangeLimit::ViewHelperOverride call it has been removed in the latest BlacklightRangeLimit version cribbing from @sandbergja pulibrary/orangelight@f3ddf37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3338