Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beginning harmful content feedback bar #3348

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

maxkadel
Copy link
Contributor

@maxkadel maxkadel commented Jan 5, 2023

  • Put behind feature flipper so we can have control of rollout and incrementally introduce feature - go to /features to turn on and test
  • Right now links just go to top and are placeholders for future tickets

Closes #3328

At bottom of page:
image

Sticky!:
image

Mobile:
image

- Put behind feature flipper so we can have control of rollout and incrementally introduce feature - go to /features to turn on and test
- Right now links just go to top and are placeholders for future tickets
@pulbot pulbot temporarily deployed to staging January 5, 2023 17:24 Inactive
@maxkadel
Copy link
Contributor Author

maxkadel commented Jan 5, 2023

Deployed to staging & feature turned on in that environment for QA.

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small accessibility improvement suggestion.

app/views/catalog/_show_harmful_content_feedback.html.erb Outdated Show resolved Hide resolved
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@coveralls
Copy link

Coverage Status

Coverage: 94.515% (-0.005%) from 94.52% when pulling 4214ee0 on i3328_feedback_bar into f66bd1c on main.

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel ! 🐡

@sandbergja sandbergja merged commit 097b576 into main Jan 5, 2023
@sandbergja sandbergja deleted the i3328_feedback_bar branch January 5, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the new feedback bar to the "record page"
4 participants