Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations Never Stop #3358

Merged
merged 7 commits into from
Jan 17, 2023
Merged

Deprecations Never Stop #3358

merged 7 commits into from
Jan 17, 2023

Conversation

leefaisonr
Copy link
Contributor

Co-authored-by: Jane Sandberg sandbergja@users.noreply.github.com

leefaisonr and others added 2 commits January 9, 2023 16:54
@leefaisonr @sandbergja
DEPRECATION WARNING: facets_from_request is deprecated and will be re…
92488e7 
…moved from a future release

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@leefaisonr @sandbergja
DEPRECATION WARNING: facet_by_field_name is deprecated and will be re…
efb25c5 
…moved from a future release (Removed without replacement)

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jan 11, 2023 •
edited
Loading

Coverage Status

Coverage: 94.442% (-0.07%) from 94.514% when pulling 0109391 on more_deprecation into ac78d93 on main.

leefaisonr and others added 3 commits January 12, 2023 15:26
@leefaisonr @sandbergja
DEPRECATION WARNING: render_hash_as_hidden_fields is deprecated and w…
9c1d53d 
…ill be removed from a future release (Use Blacklight::HiddenSearchStateComponent instead).

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@leefaisonr @sandbergja
DEPRECATION WARNING: render_range_input is deprecated and will be rem…
64c02bc 
…oved from a future release.

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@leefaisonr @sandbergja
DEPRECATION WARNING: facet_display_value is deprecated and will be re…
446688c 
…moved from blacklight 8.0.

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@sandbergja sandbergja marked this pull request as ready for review January 13, 2023 23:34
@pulbot pulbot temporarily deployed to staging January 17, 2023 15:37 Inactive
@kevinreiss kevinreiss merged commit c3f288a into main Jan 17, 2023
@kevinreiss kevinreiss deleted the more_deprecation branch January 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinreiss kevinreiss kevinreiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leefaisonr @coveralls @kevinreiss @pulbot @sandbergja