Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atom feed - respond to html #3417

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix atom feed - respond to html #3417

merged 1 commit into from
Feb 13, 2023

Conversation

maxkadel
Copy link
Contributor

Closes #3406

@pulbot pulbot temporarily deployed to staging February 13, 2023 14:17 Inactive
@coveralls
Copy link

Coverage Status

Coverage: 94.393%. Remained the same when pulling c72ad96 on atom_feed into ddf15f8 on main.

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel !

it 'renders the page' do
get url
expect(response).to be_successful
expect(response.content_type).to eq("application/atom+xml; charset=utf-8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -15,7 +15,7 @@ xml.entry do

xml.author { xml.name(document.to_semantic_values[:author].first) } if document.to_semantic_values.key? :author

with_format('html') do
with_format(:html) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 I can't believe this was all it took to break our feed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atom XML Returns as HTML
4 participants