Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3505 electronic delivery #3511

Merged
merged 2 commits into from
Apr 14, 2023
Merged

3505 electronic delivery #3511

merged 2 commits into from
Apr 14, 2023

Conversation

christinach
Copy link
Member

closes #3505

$(target).collapse('hide');
$("input[name='" + this.name + "']").each(function() {
const target = $(this).attr('data-target');
$(target).collapse('hide');

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
@christinach christinach force-pushed the 3505-electronic-delivery branch 2 times, most recently from 0602ff0 to da49e75 Compare April 13, 2023 22:17
Run eslint on app/assets/javascripts/requests/requests.js
@pulbot pulbot temporarily deployed to qa April 13, 2023 22:22 Inactive
@coveralls
Copy link

coveralls commented Apr 13, 2023

Coverage Status

Coverage: 95.224%. Remained the same when pulling 5968ad9 on 3505-electronic-delivery into 3c29e3e on main.

…button

deactivate and activate button when user adds or removes title from edd
@christinach christinach marked this pull request as ready for review April 14, 2023 13:14
@pulbot pulbot temporarily deployed to qa April 14, 2023 13:15 Inactive
@christinach
Copy link
Member Author

please squash when merging

Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested our major scenarios for requests with this PR.

@kevinreiss kevinreiss merged commit 919ed9d into main Apr 14, 2023
@kevinreiss kevinreiss deleted the 3505-electronic-delivery branch April 14, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users cannot request electronic delivery for ReCAP Locations
4 participants