-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade blacklight-marc gem to 7.2 #3516
Conversation
Remove commented out code
* Adjust file names and paths to match upstream * Refactor our customizations
@@ -0,0 +1,33 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring some of our complex custom logic into classes
@@ -0,0 +1,214 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new path for app/models/concerns/solr/document/marc.rb. Git isn't recognizing it as the same file, though.
@@ -24,15 +24,6 @@ def openurl_ctx_kev | |||
ctx.kev | |||
end | |||
|
|||
## double check what are valid openURL formsts in the catatlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removing a commented-out method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandbergja I have to block this. It's breaking the app when I deploy.
I deployed to catalog-staging. I looked into the syslog in both catalog-staging1 and 2. there is only one error from sneakers but it triggered only once. Did you deploy the branch successfully on Friday? |
I tried catalog-qa as well because we track honeybadger errors but can't see sth meaningful so far. checked syslog, lastlog and alma_qa.log |
It looks like there is an error in the nginx logs -- thanks for catching this, @christinach ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sandbergja 🍄
Incremental step on the way to #3397