Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade blacklight-marc gem to 7.2 #3516

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Upgrade blacklight-marc gem to 7.2 #3516

merged 3 commits into from
Apr 17, 2023

Conversation

sandbergja
Copy link
Member

Incremental step on the way to #3397

* Adjust file names and paths to match upstream
* Refactor our customizations
@pulbot pulbot temporarily deployed to staging April 14, 2023 22:36 Inactive
@@ -0,0 +1,33 @@
# frozen_string_literal: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring some of our complex custom logic into classes

@@ -0,0 +1,214 @@
# frozen_string_literal: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new path for app/models/concerns/solr/document/marc.rb. Git isn't recognizing it as the same file, though.

@@ -24,15 +24,6 @@ def openurl_ctx_kev
ctx.kev
end

## double check what are valid openURL formsts in the catatlog
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing a commented-out method

@pulbot pulbot temporarily deployed to staging April 17, 2023 13:35 Inactive
@pulbot pulbot temporarily deployed to qa April 17, 2023 13:44 Inactive
@pulbot pulbot temporarily deployed to staging April 17, 2023 14:00 Inactive
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandbergja I have to block this. It's breaking the app when I deploy.

@christinach
Copy link
Member

I deployed to catalog-staging. I looked into the syslog in both catalog-staging1 and 2. there is only one error from sneakers but it triggered only once.
Stopping orangelight-sneakers...
Apr 17 14:01:50 catalog-staging2 sneakers[22769]: Unexpected error undefined method `each' for nil:NilClass
Apr 17 14:01:50 catalog-staging2 sneakers[22769]: thread.backtrace.each {|bt|
Apr 17 14:01:50 catalog-staging2 sneakers[22769]: ^^^^^

Did you deploy the branch successfully on Friday?

@pulbot pulbot temporarily deployed to qa April 17, 2023 14:16 Inactive
@christinach
Copy link
Member

christinach commented Apr 17, 2023

I tried catalog-qa as well because we track honeybadger errors but can't see sth meaningful so far. checked syslog, lastlog and alma_qa.log

@pulbot pulbot temporarily deployed to staging April 17, 2023 14:48 Inactive
@sandbergja
Copy link
Member Author

It looks like there is an error in the nginx logs -- thanks for catching this, @christinach !

@sandbergja sandbergja marked this pull request as draft April 17, 2023 14:58
@pulbot pulbot temporarily deployed to staging April 17, 2023 15:35 Inactive
@coveralls
Copy link

Coverage Status

Coverage: 95.23% (+0.007%) from 95.224% when pulling 7116b36 on blacklight-marc into e2dd482 on main.

@sandbergja sandbergja marked this pull request as ready for review April 17, 2023 15:47
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sandbergja 🍄

@christinach christinach merged commit d6a4634 into main Apr 17, 2023
@christinach christinach deleted the blacklight-marc branch April 17, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants