Show page links directly to aeon, rather than a redirect #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, refactor aeon url generation into its own class
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sandbergja
force-pushed
the
refactor-more-ctx
branch
from
dcec0f9
to
a78ac70
Compare
…fic holding or item
sandbergja
force-pushed
the
refactor-more-ctx
branch
from
7c851b0
to
96c59e2
Compare
sandbergja
force-pushed
the
refactor-more-ctx
branch
from
2ae7fcb
to
83198ff
Compare
sandbergja
force-pushed
the
refactor-more-ctx
branch
from
83198ff
to
0277d63
Compare
kevinreiss
approved these changes
May 16, 2023
| expect(subject).to include('ItemNumber=32101071302192') | ||
| end | ||
| it('takes enumeration from the item') do | ||
| expect(subject).to include('rft.volume=Vol+1%3A+no.+1+-+4') |
There was a problem hiding this comment.
Per Aeon's OpenURL mapping table it should accept "rft.volume" as a valid param for volume info, however by manual test it does not. It did accept just plain "volume". The Aeon form param is literally "ItemVolume", maybe for now we should pass enumeration as that param.
|
Thank you for adding the component and making the new Aeon OpenURL class @sandbergja. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes information from both the host and constituent record, closing #3273
Still to-do: