Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3569: add a sequence diagram of ILLiad request #3575

Merged
merged 2 commits into from
May 25, 2023
Merged

i3569: add a sequence diagram of ILLiad request #3575

merged 2 commits into from
May 25, 2023

Conversation

sandbergja
Copy link
Member

closes #3569

maxkadel
maxkadel approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to block, but should we have an "if the transaction is unsuccessful" case?

@sandbergja sandbergja requested a review from maxkadel May 25, 2023 14:54
maxkadel
maxkadel approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja! 🍄

@maxkadel maxkadel merged commit 9ba9131 into main May 25, 2023
7 of 8 checks passed
@maxkadel maxkadel deleted the i3569-illiad-request-process branch May 25, 2023 14:58
@coveralls
Copy link

Coverage Status

Coverage: 95.284%. Remained the same when pulling 21fcc4e on i3569-illiad-request-process into 57af283 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkadel maxkadel maxkadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an ILLiad request sequence diagram
3 participants
@sandbergja @coveralls @maxkadel