Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NullItem inherits from Item and SimpleDelegator #3613

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

maxkadel
Copy link
Contributor

When NullItem does not have the correct inheritance, it does not behave like a hash, as Item does, raising errors.

Connected to #3599

maxkadel and others added 2 commits June 7, 2023 10:26
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Isha Sinha <ishasinha1@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Liz Garcia <lizgarciao@users.noreply.github.com>
Co-authored-by: Ryan Laddusaw <rladdusaw@users.noreply.github.com>
@pulbot pulbot temporarily deployed to staging June 20, 2023 18:53 Inactive
@coveralls
Copy link

Coverage Status

coverage: 95.369% (+0.001%) from 95.368% when pulling 3c31b5e on i3599_too_many_aeon into dbb2573 on main.

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel ! 🦄

@sandbergja sandbergja merged commit 3723ad5 into main Jun 20, 2023
10 checks passed
@sandbergja sandbergja deleted the i3599_too_many_aeon branch June 20, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants