Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I3498 requests html bug #3625

Merged
merged 5 commits into from
Jun 29, 2023
Merged

I3498 requests html bug #3625

merged 5 commits into from
Jun 29, 2023

Conversation

maxkadel
Copy link
Contributor

Connected to #3498

maxkadel and others added 5 commits June 27, 2023 14:43
It looks like maybe the `single_pickup` method in app/helpers/requests/application_helper.rb, specifically the `.to_json` called on the value, is causing a problem with this item, but removing it breaks other items, I'm not sure why this one is behaving differently
- As far as I can tell, the .html_safe does not impact display, but it was a hypothesis I tested.
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @maxkadel 🦄

@coveralls
Copy link

Coverage Status

coverage: 95.369% (-0.03%) from 95.403% when pulling 34e08df on i3498_requests_html_bug into a0f484a on main.

@maxkadel maxkadel merged commit 45a3e76 into main Jun 29, 2023
7 of 9 checks passed
@maxkadel maxkadel deleted the i3498_requests_html_bug branch June 29, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants