i3645 finish new numismatics form #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
commented
Aug 17, 2023
| @@ -120,3 +120,13 @@ | |||
| .row .range_limit input.range_begin, .row .range_limit input.range_end { | |||
| width: 5em; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Removing and improving some inline CSS from my previous PR
sandbergja
commented
Aug 17, 2023
Comment on lines
+40
to
+51
| <div class="search-submit-buttons clearfix col-sm-7"> | ||
| <% if sort_fields_select %> | ||
| <div class="form-group sort-buttons pull-left"> | ||
| <%= content_tag :label, t('blacklight.advanced_search.form.sort_label'), id: 'advanced-search-sort-label', for: 'sort', class: 'control-label' %> | ||
| <%= sort_fields_select %> | ||
| </div> | ||
| <% end %> | ||
| <div class="submit-buttons pull-right form-group"> | ||
| <%= submit_tag t('blacklight.advanced_search.form.search_btn_html'), class: 'btn btn-primary advanced-search-submit', id: "advanced-search-submit" %> | ||
| </div> | ||
|
|
||
| </div> |
There was a problem hiding this comment.
Adding the two elements that were missing from the form previously
sandbergja
commented
Aug 17, 2023
| @@ -33,13 +33,31 @@ | |||
| allow(view_context).to receive(:facet_limit_for).and_return(nil) | |||
| end | |||
|
|
|||
| it "renders fields in the correct order" do | |||
| it "renders all expected fields" do | |||
There was a problem hiding this comment.
This "it" previously didn't accurately describe what was being tested
sandbergja
force-pushed
the
i3645-numismatics-builtin-advanced-2
branch
from
aa8d403
to
cfc5c35
Compare
christinach
reviewed
Aug 17, 2023
There was a problem hiding this comment.
@sandbergja thank you for your work on the blacklight upgrade! 🍄
When I tested the numismatics form the one bug I can report, but it is not consistent between the fields is that when I tried to edit a search with no results it gave me the '404 something went wrong page'. honeybadger error
sandbergja
force-pushed
the
i3645-numismatics-builtin-advanced-2
branch
from
020290c
to
e57be3f
Compare
christinach
approved these changes
Aug 18, 2023
| @@ -66,6 +66,7 @@ def facets_for_advanced_search_form(solr_p) | |||
| # search form, so that the form displays accurate counts for | |||
| # them in its dropdowns | |||
| advanced_search_facets = blacklight_config.advanced_search.form_solr_parameters['facet.field'] | |||
| solr_p[:fq]&.compact! | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3645
To review, make sure that the "View components numismatics" feature is enabled