I3412 built in advanced search form #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still need fields to come from dropdown, rather than displaying all the fields at once. Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Next steps: Write a test in the component spec, make a parallel to the guided search fields partial that aligns with the new advanced search (e.g. "clause_1_field", etc.) Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
- Search form is searching correct fields - Needs more testing - Booleans are not actually hooked up correctly - not sure if this is possible within json syntax - Locally there are some failing tests when I turn the feature on for everything, mostly in browse specs - don't know if this is related to local solr config change
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
sandbergja
requested changes
Aug 24, 2023
spec/components/orangelight/advanced_search_form_component_spec.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #3412
Current status:
spec/features/advanced_searching_spec.rbpass when run individually; however, not in the context of the whole suite, because the controller is not re-loaded, so the json dsl is not used when it should be. This should resolve if Move Flipflop out of controller #3695 is resolved.Error: Pivot Facet needs at least one field name:RSolr::Error::Http - 400 Bad Request Error: Error when parsing json query, expect a json object here, but found : null