Add erb-lint with github accessibility rules #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
force-pushed
the
erblint-accessibility
branch
2 times, most recently
from
81a789e
to
bbe413a
Compare
Removed title from a tag to satisfy: The title attribute should never be used for an a tag Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com> Co-authored-by: Liz Garcia <lizgarciao@users.noreply.github.com>
…should have a unique accessible name via `aria-label` or `aria-labelledby` Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
The title attribute should never be used unless for an `<iframe>` as it is inaccessible for several groups of users Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
* Add aria-label in navigation landmark Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
* Update aria-label to sentence case Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
* Add title attribute to iframe Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
* removed aria-hidden Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
* Exclude files where the error triggers in an interactive element. Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
* Fixed GitHub::Accessibility::NoTitleAttribute * Exclude false positive GitHub::Accessibility::NoTitleAttribute Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
…in a decorative <svg> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
christinach
force-pushed
the
erblint-accessibility
branch
from
737c6b3
to
063146a
Compare
2 tasks
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
christinach
force-pushed
the
erblint-accessibility
branch
from
063146a
to
c5f626c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3714
This PR will be a good resource for accessibility learning, and learning about the specific erb-lint rules. Would appreciate to not squash these commits.