Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update header css to fit in screen less than 322px #1918 #3862

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Update header css to fit in screen less than 322px #1918 #3862

merged 1 commit into from
Dec 1, 2023

Conversation

christinach
Copy link
Member

closes #1918

I don't think there is a screen less than 306px. In 305px the header will wrap.

See the following screenshoot. The top one is my local. The bottom one is production.

Screenshot 2023-12-01 at 9 23 26 AM

@christinach
Copy link
Member Author

The branch is deployed in catalog-qa

@coveralls
Copy link

Coverage Status

coverage: 95.408%. remained the same
when pulling debebed on 1918-header-small-screen
into 56ca22d on main.

kevinreiss
kevinreiss approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinreiss kevinreiss merged commit 0318c09 into main Dec 1, 2023
11 checks passed
@kevinreiss kevinreiss deleted the 1918-header-small-screen branch December 1, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinreiss kevinreiss kevinreiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should update the header for screen width less than 322 px
3 participants
@christinach @coveralls @kevinreiss