Remove tooltip. Remove warning icon and reading room icon from search results. Remove tooltip title #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the branch is deployed on catalog-staging |
sandbergja
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks, @christinach ! It will be good to get all of these out of the catalog. My only question is: do we want to get rid of some of the tests as well, rather than setting them to not_to? Not a blocker! 🐬
spec/system/searching_spec.rb
Outdated
| @@ -68,9 +68,9 @@ | |||
|
|
|||
| # We don't have the on-site icon at the moment. It appears as available. We might add it back in the future. | |||
| context 'with items which are from aeon locations' do | |||
| it 'renders an accessible warning icon for requesting an item in a reading room' do | |||
| it 'does not render a warning icon for requesting an item in a reading room' do | |||
There was a problem hiding this comment.
I can remove them. I kept them to make sure the icon is not there anymore. But it can be deleted now
| it 'renders the typical title tooltip' do | ||
| expect(subject.css('a').attribute('title').text).to eq('Request to view in Reading Room') | ||
| it 'does not render a tooltip' do | ||
| expect(subject.css('a').attribute('title')).to be_falsey |
christinach
force-pushed
the
remove-tooltip
branch
from
a36fc2c
to
3979032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3885
closes #3906
closes #3907
part of #3878