Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed label for value #3912

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Fixed label for value #3912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234a45e
Fixed label for value
Dec 18, 2023
594c909
Merge branch 'main' into 3884-label-for-match
rladdusaw Jan 8, 2024
82facdf
Merge branch 'main' into 3884-label-for-match
rladdusaw Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/requests/request/_requestable_fill_in_field.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</td>
<td class='request--options' <%= 'colspan="2"'.html_safe unless table_sorter_present?(requestable_list) %>>
<fieldset class="form-group">
<label class="control-label <%= 'col-sm-6'.html_safe unless table_sorter_present?(requestable_list) %>" for="user_supplied_enum">
<label class="control-label <%= 'col-sm-6'.html_safe unless table_sorter_present?(requestable_list) %>" for="requestable_user_supplied_enum_<%= "#{requestable.holding.keys[0]}" %>">
If the specific volume does not appear in the list below, please enter it here:
</label>
<div class="col-sm-6">
Expand Down
2 changes: 2 additions & 0 deletions spec/features/requests/request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,8 @@
expect(page).to have_content 'If the specific volume does not appear in the list below, please enter it here:'
expect(page).to have_content 't. 2, no 2 (2018 )' # include enumeration and chron
expect(page).to have_content 't. 3, no 2 (2019 )' # include enumeration and chron
expect(page).to have_field('requestable_user_supplied_enum_22547424510006421')
expect(page).to have_selector('label[for=requestable_user_supplied_enum_22547424510006421]')
within(".user-supplied-input") do
check('requestable_selected')
end
Expand Down
Loading