Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results - Update javascript to use the status value from the SCSB bibdata availability response #4002

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

christinach
Copy link
Member

closes #4001

expect(mixed_result.hasClass('badge-secondary')).toBe(true);
expect(mixed_result.text()).toEqual("Some items not available");
});
test('search results - SCSB availability - Unavailable', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated spec for this PR. test('search results - SCSB availability - Unavailable', () => {

The rest are fixes from eslint/prettier.

@coveralls
Copy link

Coverage Status

coverage: 95.555%. remained the same
when pulling 409aad9 on 4001-scsb-search-use-bibdata-status
into 68bfee3 on main.

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @christinach 🐬

@sandbergja sandbergja merged commit b4cd64a into main Apr 9, 2024
11 checks passed
@sandbergja sandbergja deleted the 4001-scsb-search-use-bibdata-status branch April 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update availability JS and remove the SCSB availability status update on the search results page
3 participants