Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to show deaccessioned items as being not in clancy #4038

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Add check to show deaccessioned items as being not in clancy #4038

merged 2 commits into from
Jun 18, 2024

Conversation

rladdusaw
Copy link
Contributor

@rladdusaw rladdusaw commented Jun 18, 2024 •
edited
Loading

Resolves #4017

Ryan Laddusaw and others added 2 commits June 18, 2024 10:22
@winsice-ng
Add check to show deaccessioned items as being not in clancy
afc10ca 
Co-authored-by: Winsice Ng <winsice-ng@users.noreply.github.com>
@winsice-ng
Rubocop
0b25969 
Co-authored-by: Winsice Ng <winsice-ng@users.noreply.github.com>
@coveralls
Copy link

Coverage Status

coverage: 95.572%. remained the same
when pulling 0b25969 on 4017-marquand-items-not-requestable
into 150a3ea on main.

@rladdusaw rladdusaw marked this pull request as ready for review June 18, 2024 16:25
kevinreiss
kevinreiss approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the "green" test suite Ryan and I also manually tested in staging the various marquand recap and stacks request scenarios and things were working as far as we can tell.

@kevinreiss kevinreiss merged commit 2029d98 into main Jun 18, 2024
10 checks passed
@kevinreiss kevinreiss deleted the 4017-marquand-items-not-requestable branch June 18, 2024 16:30
@kevinreiss
Copy link
Member

For issue #4017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinreiss kevinreiss kevinreiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate - Certain Marquand Stacks Items are not Requestable for Physical Delivery
4 participants
@rladdusaw @coveralls @kevinreiss @pulbot