Separating the orcid.js from application.js and ensuring that `de…

…scribe/` is prefixed to the Webpack manifest paths

app/javascript/packs/application.js

@@ -7,9 +7,7 @@ import Rails from "@rails/ujs"
 import Turbolinks from "turbolinks"
 import * as ActiveStorage from "@rails/activestorage"
 import "channels"
-import { isOrcid } from './orcid'
-window.isOrcid = isOrcid;
 
 Rails.start()
 Turbolinks.start()
-ActiveStorage.start()
+ActiveStorage.start()

app/javascript/packs/orcid.js

@@ -1,5 +1,9 @@
-export function isOrcid(value) {
+function isOrcid(value) {
   // Notice that we allow for an "X" as the last digit.
   // Source https://gist.github.com/asencis/644f174855899b873131c2cabcebeb87
   return /^(\d{4}-){3}\d{3}(\d|X)$/.test(value)
 };
+
+window.isOrcid = isOrcid;
+
+export { isOrcid };

app/views/layouts/application.html.erb

@@ -7,7 +7,6 @@
     <%= csp_meta_tag %>
 
     <%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %>
-    <%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
 
     <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap-icons@1.7.1/font/bootstrap-icons.css">
     <link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
@@ -31,4 +30,6 @@
     </div>
     <%= render partial: 'shared/footer' %>
   </body>
+  <%= javascript_pack_tag 'orcid', 'data-turbolinks-track': 'reload' %>
+  <%= javascript_pack_tag 'application', 'data-turbolinks-track': 'reload' %>
 <% end %>

config/webpacker.yml

@@ -4,7 +4,7 @@ default: &default
   source_path: app/javascript
   source_entry_path: packs
   public_root_path: public
-  public_output_path: packs
+  public_output_path: describe/packs
   cache_path: tmp/cache/webpacker
   webpack_compile_output: true