Allow blob to exists and reattach it #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncole
force-pushed
the
i358-existing-blob
branch
from
5b0e87d
to
c7d2a5a
Compare
Also remove add_post_curation_uploads as we should never be using it. It would cause key conflicts all the time if we did, since the key does not include the bucket
carolyncole
force-pushed
the
i358-existing-blob
branch
from
c7d2a5a
to
8d67007
Compare
carolyncole
commented
Sep 1, 2022
| @@ -577,7 +571,6 @@ | |||
| stub_request(:put, /#{bucket_url}/).to_return(status: 200) | |||
|
|
|||
| work.complete_submission!(user) | |||
| work.save | |||
There was a problem hiding this comment.
The complete_submission! causes save to be called. create_submission no bang would require a save
bess
approved these changes
Sep 1, 2022
bess
pushed a commit
that referenced
this pull request
Sep 6, 2022
Also remove add_post_curation_uploads as we should never be using it. It would cause key conflicts all the time if we did, since the key does not include the bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove add_post_curation_uploads as we should never be using it. It would cause key conflicts all the time if we did, since the key does not include the bucket
fixes #358