Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from webpacker to vite #397

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Moving from webpacker to vite #397

merged 2 commits into from
Sep 9, 2022

Conversation

carolyncole
Copy link
Member

Utilized https://vite-ruby.netlify.app/guide/migration.html#webpacker-%F0%9F%93%A6 and referenced pulibrary/orangelight#3164

This was complicated by the fact that the servers utilize the describe path in their base url.

@pulbot pulbot temporarily deployed to staging September 8, 2022 19:42 Inactive
@carolyncole carolyncole marked this pull request as ready for review September 8, 2022 19:45
bess
bess previously approved these changes Sep 8, 2022
Copy link
Contributor

@bess bess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! I tried this out in staging and it seems to work great.

@pulbot pulbot temporarily deployed to staging September 9, 2022 12:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants