S3 key already contains the DOI #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncole
force-pushed
the
s3-keys
branch
from
e6247b7
to
2fa220a
Compare
carolyncole
force-pushed
the
s3-keys
branch
4 times, most recently
from
567ab81
to
cf4f0e1
Compare
Lets utilize the key instead of the file name. This stops an infinite loop from accuring in tests and for S3 files to not get added repeatedly when s3 is queried. See https://pdc-describe-staging.princeton.edu/describe/works/75 for an example of a work where the files got added each time the work was saved
carolyncole
force-pushed
the
s3-keys
branch
from
cf4f0e1
to
546b422
Compare
hectorcorrea
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's utilize the key instead of the file name. This stops an infinite loop from occurring in tests when we trigger the validation and for S3 files to not get added repeatedly when s3 is queried. See https://pdc-describe-staging.princeton.edu/describe/works/75 for an example of a work where the files got added each time the work was saved
ActiveStorage::File to_s changes the slashes to underscores, so the names were not matching and the