Ensuring that multiple titles can be updated for an approved Work #866
Conversation
| end | ||
| end | ||
|
|
||
| context "when authenticated as the submitter of the Work" do |
There was a problem hiding this comment.
This seems to be the failing case. I can ensure that this is fully resolved.
jrgriffiniii
force-pushed
the
issues-833-mult-titles
branch
2 times, most recently
from
c0cc843
to
1925d1f
Compare
|
I was failing to reproduce these errors locally, I am going to proceed with resolving the outstanding failing test. |
jrgriffiniii
force-pushed
the
issues-833-mult-titles
branch
from
1925d1f
to
70f8ab1
Compare
There was a problem hiding this comment.
@jrgriffiniii I am unsure if by fixing this "bug" we are introducing a bug. We should check to see if we still want to limit when a depositor can edit the metadata before this gets merged.
I have no technical issue with this PR and I am not really requesting any changes, I just want to block it from being merged until we can discuss it with RDOS.
| @@ -114,8 +114,6 @@ def update | |||
| if current_user.blank? || !@work.editable_by?(current_user) | |||
| Rails.logger.warn("Unauthorized attempt to update work #{@work.id} by user #{current_user.uid}") | |||
| redirect_to root_path | |||
| elsif @work.approved? && @work.submitted_by?(current_user) | |||
There was a problem hiding this comment.
The requirement that a user can not edit an item they deposited was ticketed here: #255. Does removing this code introduce a bug?
|
Given the discussion held on 01/20/23, it was confirmed by the Product Owners that submitters should not be able to modify metadata. |
Resolves #833