Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Commit

Permalink
Merge pull request #985 from pulibrary/all_collection_dont_embed_mani…
Browse files Browse the repository at this point in the history
…fests

Don't embed manifests in all collections manifest.
  • Loading branch information
escowles committed Feb 1, 2017
2 parents 9376c19 + fcef141 commit f0f1c38
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 6 additions & 2 deletions app/services/sparse_member_collection_manifest.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ def apply(manifest)
manifest['collections'] += [self.manifest]
end

def child_manifest_factory
OnlyPropertyManifestBuilder
def manifest_builders
nil
end

def manifest_builder_class
IIIF::Presentation::Collection.new
end

def sequence_builder
Expand Down
4 changes: 2 additions & 2 deletions spec/services/all_collections_manifest_builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
expect(manifest_json["collections"].length).to eq 1
expect(manifest_json["collections"].first["metadata"]).not_to be_blank
end
it "embeds manifests" do
it "doesn't embed manifests" do
c = FactoryGirl.create(:collection)
s = FactoryGirl.create(:scanned_resource_with_multi_volume_work)
s2 = FactoryGirl.create(:scanned_resource)
Expand All @@ -21,7 +21,7 @@
s2.save!

expect(manifest_json["collections"].length).to eq 1
expect(manifest_json["collections"].first["manifests"]).not_to be_blank
expect(manifest_json["collections"].first["manifests"]).to be_blank
end
it "doesn't populate manifests" do
FactoryGirl.create(:collection)
Expand Down

0 comments on commit f0f1c38

Please sign in to comment.