Initialize datadog in staging or production only #1090

eliotjordan · 2017-03-13T22:15:29Z

Datadog should only be initialized in staging or production environments. This PR removes the error message:

E, [2017-03-13T17:00:52.579684 #46229] ERROR -- : Failed to open TCP connection to localhost:8126 (Connection refused - connect(2) for "localhost" port 8126)

tpendragon · 2017-03-13T22:16:53Z

config/initializers/datadog.rb

-  default_service: "Plum (#{Rails.env})"
-}
-Datadog::Monkey.patch_all
+if ENV['RAILS_ENV'] == 'staging' || ENV['RAILS_ENV'] == 'production'


Can we do Rails.env.staging? || Rails.env.production? instead?

coveralls · 2017-03-13T22:56:51Z

Coverage remained the same at 99.806% when pulling ce1a6e9 on datadog_in_dev into 51d85d0 on master.

eliotjordan added the in progress label Mar 13, 2017

tpendragon reviewed Mar 13, 2017

View reviewed changes

Initialize datadog in staging or production only

ce1a6e9

eliotjordan force-pushed the datadog_in_dev branch from 207dd6c to ce1a6e9 Compare March 13, 2017 22:27

tpendragon merged commit e1efa89 into master Mar 13, 2017

tpendragon deleted the datadog_in_dev branch March 13, 2017 23:25

tpendragon removed the in progress label Mar 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initialize datadog in staging or production only #1090

Initialize datadog in staging or production only #1090

eliotjordan commented Mar 13, 2017 •

edited

tpendragon Mar 13, 2017

eliotjordan Mar 13, 2017

coveralls commented Mar 13, 2017 •

edited

Initialize datadog in staging or production only #1090

Initialize datadog in staging or production only #1090

Conversation

eliotjordan commented Mar 13, 2017 • edited

tpendragon Mar 13, 2017

Choose a reason for hiding this comment

eliotjordan Mar 13, 2017

Choose a reason for hiding this comment

coveralls commented Mar 13, 2017 • edited

eliotjordan commented Mar 13, 2017 •

edited

coveralls commented Mar 13, 2017 •

edited