Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Add dct_source and suppressed fields to geoblacklight solr document #1322

Merged
merged 2 commits into from
May 31, 2017
Merged

Add dct_source and suppressed fields to geoblacklight solr document #1322

merged 2 commits into from
May 31, 2017

Conversation

eliotjordan
Copy link
Member

Adds dct_source_sm and suppressed_b to Image Work geoblacklight documents. Closes #1320

@eliotjordan eliotjordan requested a review from tampakis May 30, 2017 23:46
@eliotjordan eliotjordan removed the request for review from tampakis May 31, 2017 00:17
tampakis
tampakis reviewed May 31, 2017
View reviewed changes
spec/services/discovery/geoblacklight_document_spec.rb
end

it 'returns a suppressed document with a source field' do
expect(document[:suppressed_b]).to eq true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test that asserts that a mapset would exclude the suppressed field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@coveralls
Copy link

coveralls commented May 31, 2017 •
edited
Loading

Coverage Status

Coverage increased (+9.0e-05%) to 99.814% when pulling 0035009 on 1320-dct-source into 819616a on master.

@tampakis tampakis merged commit 258fcba into master May 31, 2017
@tampakis tampakis deleted the 1320-dct-source branch May 31, 2017 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tampakis tampakis tampakis left review comments

Assignees
No one assigned
Labels
GeoWorks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eliotjordan @coveralls @tampakis