-
Notifications
You must be signed in to change notification settings - Fork 12
ActiveRecord-based configuration for mapping fields to Vocabularies #1344
Conversation
Spinning this up to take a look now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple simple deletes, but some other questions:
- We need a way to get to the "Ephemera Projects" screen.
- Should we index + facet "Ephemera Project"? Or maybe associate it with a collection?
- I don't see any changes to
ability.rb
orload_and_authorize_resource
- are permissions not being checked?
@@ -0,0 +1,3 @@ | |||
# Place all the behaviors and hooks related to the matching controller here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete?
@@ -0,0 +1,3 @@ | |||
# Place all the behaviors and hooks related to the matching controller here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete?
@@ -0,0 +1,3 @@ | |||
// Place all the styles related to the EphemeraFields controller here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete?
@@ -0,0 +1,3 @@ | |||
// Place all the styles related to the EphemeraProjects controller here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete?
I've deleted the unused javascripts/stylesheets and added some navigation to the front page. I've also added basic access control enforcement, but will defer more auth work to #1302
For indexing, the box does index the EphemeraProject name and id, and that displays on the show page. EphemeraFolders just index the id so it can be used to find the appropriate controlled vocab fields. We could also index the EphemeraProject name there too — maybe we should just index it the same way as Collections, so we could effectively use the EphemeraProject instead of Collections? |
👍 (Now 👎) Edit: I changed my mind - probably not. Collections have meaning for DPUL, after all |
I was torn about this because I think the EphemeraProject is going to map to a Collection, but clearly serves a very different purpose. And I definitely don't want to have a bunch of redundant Collection behavior on EphemeraProject. So I'll index it as its own thing and provide a link from the EphemeraFolder like is already there for EphemeraBox, to make it easier to navigate up to the project. |
99d40f1
to
cbb7be5
Compare
Adds two new ActiveRecord models for managing Ephemera:
The new workflow for creating a new ephemera project is:
Fixes #1255