This repository has been archived by the owner on May 14, 2022. It is now read-only.
Ensures that the Universal Viewer is not rendered for invalid IIIF resources #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
force-pushed
the
issues-1429-jrgriffiniii-manifest-no-sequences
branch
from
649ca69
to
c9e348d
Compare
jrgriffiniii
force-pushed
the
issues-1429-jrgriffiniii-manifest-no-sequences
branch
2 times, most recently
from
54414ce
to
f55c7c4
Compare
jrgriffiniii
force-pushed
the
issues-1429-jrgriffiniii-manifest-no-sequences
branch
from
f55c7c4
to
f9f5cbd
Compare
jrgriffiniii
changed the title
escowles
reviewed
Aug 17, 2017
| get :manifest, params: { id: coll.id, format: :json } | ||
|
|
||
| response_json = JSON.parse(response.body) | ||
| expect(response_json).to be_empty |
There was a problem hiding this comment.
I think it would be good to also check the response status code.
escowles
reviewed
Aug 17, 2017
| get :manifest, params: { id: "test2", format: :json } | ||
|
|
||
| response_json = JSON.parse(response.body) | ||
| expect(response_json).to be_empty |
There was a problem hiding this comment.
Same as above: we should check the status code, too.
|
This looks good — the only changes I'd like to see are making sure we get the response status codes we expect, since they're important for triggering client error handling behavior. |
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
issues-1429-jrgriffiniii-manifest-no-sequences
branch
from
39bd78a
to
a3907f6
Compare
jrgriffiniii
force-pushed
the
issues-1429-jrgriffiniii-manifest-no-sequences
branch
from
a3907f6
to
38d5a74
Compare
…for resources where the IIIF Manifest is empty or invalid Addressing styling issues Structuring a test suite for the Hyrax::Manifest Module Extending the PolymorphicManifestBuilder test suites for manifest error handling; Resolving issues relating to the Rails routes for the Hyrax::Manifest test suite Ensuring that cases where the IIIF Manifest is invalid or empty no longer triggers an alert, but logs a warning
…fest methods for the CollectionsController Resolving styling issues Ensuring that the test suites for CollectionsController, EphemeraFoldersController, Manifest Increasing the test coverage by implementing a test suite for the CollectionManifest Module Tracking the modifications CollectionsManifest and the test suite Manifest
jrgriffiniii
force-pushed
the
issues-1429-jrgriffiniii-manifest-no-sequences
branch
from
38d5a74
to
316276d
Compare
jrgriffiniii
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1429 by ensuring that the Universal Viewer is not rendered for resources where the IIIF Manifest is empty or invalid