This repository has been archived by the owner on May 14, 2022. It is now read-only.
Combine bulk label and reorder views. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The combined UI looks good, and I was able to renumber pages just fine. But I haven't been able to get reordering working. I get the error "Unable to save new order." as a flash message. |
|
Huh, I wonder if style fixes broke it. I'll take a look after lunch. |
| @@ -1,44 +0,0 @@ | |||
| require 'rails_helper' | |||
There was a problem hiding this comment.
It would be nice to keep these tests.
There was a problem hiding this comment.
Good call. Moved these over.
Some work on flash messages needs to be done, but this closes #217.
tpendragon
force-pushed
the
merge_reorder_label
branch
from
b5e815c
to
17882d5
Compare
|
@escowles Could you try to debug what's going on with reordering on your side? I can't get it to break |
escowles
added a commit
that referenced
this pull request
Dec 7, 2015
Combine bulk label and reorder views.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work on flash messages needs to be done, but this closes #217.