This repository has been archived by the owner on May 14, 2022. It is now read-only.
Adding holding location backed by bibdata location service - closes #389 #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escowles
force-pushed
the
location
branch
2 times, most recently
from
03688cb
to
4ab3f1d
Compare
escowles
changed the title
|
|
||
| private | ||
|
|
||
| def attribute_value_to_html(value) |
There was a problem hiding this comment.
Wouldn't it be more efficient to change the API to location_service = HoldingLocationService.new(value) (or .find), and then have instance methods for email/label/phone?
tpendragon
pushed a commit
that referenced
this pull request
Jan 29, 2016
Adding holding location backed by bibdata location service - closes #389
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renaming several spec files that were misnamed.