Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Use the database for minter state #802

Merged
merged 2 commits into from
Nov 2, 2016
Merged

Use the database for minter state #802

merged 2 commits into from
Nov 2, 2016

Conversation

escowles
Copy link
Member

@escowles escowles commented Nov 1, 2016

Fixes #801

@tpendragon
Copy link
Contributor

Does this mean we can delete that minter_state class we have copied over?

@escowles
Copy link
Member Author

escowles commented Nov 1, 2016

We can copy the minter state from the state file to the database with the rake task:
rake active_fedora:noid:migrate:file_to_database

@tpendragon
Copy link
Contributor

@escowles
Copy link
Member Author

escowles commented Nov 1, 2016

@tpendragon I think so — let me test it locally to see.

@escowles
Copy link
Member Author

escowles commented Nov 1, 2016

Yep, it works fine without app/models/minter_state.rb now.

@tpendragon
Copy link
Contributor

I think it was a problem deploying before - can you try deploying that to staging?

@escowles
Copy link
Member Author

escowles commented Nov 1, 2016

I can try it, but it'll fail because of the plum-workers issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aa47859ed6f2a82ffe473f0b9192343edd1ba421 on db-minter-state into cdb3096 on master.

@escowles escowles force-pushed the db-minter-state branch 3 times, most recently from 554d7db to 916f82b Compare November 1, 2016 18:14
@escowles escowles force-pushed the db-minter-state branch 2 times, most recently from 8c7c869 to b3178fd Compare November 2, 2016 12:40
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.898% when pulling b3178fd99b2301c39412c28a89cc2ffb90480103 on db-minter-state into cdb3096 on master.

@escowles
Copy link
Member Author

escowles commented Nov 2, 2016

This build is deployed to staging and working now. To get the db minter working, I had to clear out an invalid seed before migrating the minter state (see instructions: https://gist.github.com/escowles/c5f1b505954ab368fa659614a2a85610)

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 11db702ab2d2942f3976298a471d3773ec64bfb9 on db-minter-state into cdb3096 on master.

@escowles
Copy link
Member Author

escowles commented Nov 2, 2016

One more thing before merging this: I changed the development database connect to use Postgres to make it easier to test — I'll change it back to sqlite now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 97899a2 on db-minter-state into cdb3096 on master.

@tpendragon tpendragon merged commit fb97ffd into master Nov 2, 2016
@tpendragon tpendragon deleted the db-minter-state branch November 2, 2016 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants