-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Does this mean we can delete that minter_state class we have copied over? |
We can copy the minter state from the state file to the database with the rake task: |
I mean can we delete this: https://github.com/pulibrary/plum/blob/master/app/models/minter_state.rb#L1 |
@tpendragon I think so — let me test it locally to see. |
55d348f
to
aa47859
Compare
Yep, it works fine without |
I think it was a problem deploying before - can you try deploying that to staging? |
I can try it, but it'll fail because of the plum-workers issue. |
Coverage remained the same at 100.0% when pulling aa47859ed6f2a82ffe473f0b9192343edd1ba421 on db-minter-state into cdb3096 on master. |
554d7db
to
916f82b
Compare
8c7c869
to
b3178fd
Compare
Coverage decreased (-0.1%) to 99.898% when pulling b3178fd99b2301c39412c28a89cc2ffb90480103 on db-minter-state into cdb3096 on master. |
b3178fd
to
11db702
Compare
This build is deployed to staging and working now. To get the db minter working, I had to clear out an invalid seed before migrating the minter state (see instructions: https://gist.github.com/escowles/c5f1b505954ab368fa659614a2a85610) |
Coverage remained the same at 100.0% when pulling 11db702ab2d2942f3976298a471d3773ec64bfb9 on db-minter-state into cdb3096 on master. |
One more thing before merging this: I changed the development database connect to use Postgres to make it easier to test — I'll change it back to sqlite now. |
11db702
to
97899a2
Compare
Fixes #801