[WIP]

.rubocop.yml

@@ -35,6 +35,10 @@ Metrics/LineLength:
     - 'spec/models/requests/pickup_lookup_spec.rb'
     - 'spec/models/requests/recall_spec.rb'
 
+Metrics/ModuleLength:
+  Exclude:
+    - 'app/helpers/requests/application_helper.rb'
+
 Metrics/PerceivedComplexity:
   Exclude:
     - 'app/models/requests/requestable.rb'

app/helpers/requests/application_helper.rb

@@ -312,11 +312,28 @@ def hidden_fields_request request
       hidden_request_tags.html_safe
     end
 
-    def suppress_login request
+    delegate :mfhd, to: :request
+
+    def sorted_requestable
+      return nil unless request.sorted_requestable
+
+      request.sorted_requestable
+    end
+
+    def mfhd_requests
+      return [] unless sorted_requestable
+
+      sorted_requestable.fetch(:mfhd, [])
+    end
+
+    def non_aeon_requests
+      mfhd_requests.select { |req| !req.aeon? }
+    end
+
+    def suppress_login(_request)
       suppress_login = false
-      if request.mfhd.present?
-        not_aeon = request.sorted_requestable[request.mfhd].select { |req| !req.aeon? }
-        if not_aeon.empty?
+      if mfhd.present?
+        if non_aeon_requests.empty?
           suppress_login = true
         end
       end