adds method for lewis library paging #432
Conversation
|
I deployed the changes to catalog-staging. In addition to marking the locations as open=false and requestable=true, I also changed the delivery location rules to only have Lewis Library as a delivery location to prevent the dropdown delivery list to show other libraries. |
There was a problem hiding this comment.
Thanks @tampakis. Looks good. Only only a couple quick questions. I also think we need to add the values "ppl" and "lewis" to this array https://github.com/pulibrary/requests/blob/master/app/controllers/requests/request_controller.rb#L142 in order to have the confirmation messages distributed for this request type. I should probably create a ticket to note that this should be re-factored to be cleanly. It's grown quite ungainly. I think we should assume every request type that is email based will send the user a confirmation email message. That is essentially what this array is.
| @@ -23,7 +23,8 @@ en: | |||
| annex_success: "Request submitted. See confirmation email with details about when your item(s) will be available." | |||
| annexa_success: "Request submitted. See confirmation email with details about when your item(s) will be available." | |||
| annexb_success: "Request submitted. See confirmation email with details about when your item(s) will be available." | |||
| ppl_success: "Request submitted. See confirmation email with details about when your item(s) will be available." | |||
| ppl_success: "" | |||
There was a problem hiding this comment.
Why did you make this one the empty string?
| @@ -69,6 +69,10 @@ def missing? | |||
| return true if item[:status] == 'Missing' | |||
| end | |||
|
|
|||
| def lewis? | |||
There was a problem hiding this comment.
scinb is the "New Book Shelf". There are only 8 items there. I think we want to leave this one out of the pageable locations.
adds method for lewis library paging
Closes #428. Closes #427.