Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine Project Vue-ness In a Better Way #80

Open
nchutchind opened this issue Jun 16, 2018 · 5 comments
Open

Determine Project Vue-ness In a Better Way #80

nchutchind opened this issue Jun 16, 2018 · 5 comments
Labels
bug Something isn't working enhancement New feature or request hacktoberfest newcomer-friendly

Comments

@nchutchind
Copy link

Currently, the code seems to look at the Languages Github lists for a project to see if it includes "Vue." This is limiting since a project made for Vue may not include any *.vue files, but pure javascript.

Why were tags/topics not used to determine Vue status? It seems like you could look through the topics for a repo for vue, vuejs, etc and get close to the same effect.

@MaximVanhove
Copy link

Indeed! Or maybe add a check to the filterOutNonVueAndZeroStars if Vue is listed as dependency?

@DonNicoJs DonNicoJs added enhancement New feature or request bug Something isn't working labels Jun 18, 2018
@DonNicoJs
Copy link
Contributor

@nchutchind @MaximVanhove Agreed that the fetch function needs some improvements / rework.
Let us all came up with the most fair but doable way to do so.
The only constraint is that we must achieve this with only one call to GitHub API ( this should not be a problem since we are using the graphql version )

@DonNicoJs
Copy link
Contributor

Link to the graphql explorer: https://developer.github.com/v4/explorer/

@DonNicoJs
Copy link
Contributor

@nchutchind I dug deeper in the the GitHub API and Tags do not seem a good way to go, as far as I understand they are tied to Releases.

About topics: not all the vuejs project have topic set up for example I just adjusted mine to contain those.
But I agree that maybe we should both check: language and topics. Now we would need a list of good topics, or maybe a very very good regex ( I am not too fond of just searching for the word: vue in the topic name)
This is the graphql query that I was playing with:

{
  user(login: "lordfuoco") {
    repositories(first: 100, privacy: PUBLIC) {
      edges {
        node {
          id
          name
          url
          stargazers {
            totalCount
          }
          languages(first: 5, orderBy: {field: SIZE, direction: DESC}) {
            edges {
              node {
                name
              }
            }
          },
          repositoryTopics(first: 10) {
            edges {
              node {
                topic {
                  id,
                  name
                }
              }
            }
          }
        }
      }
    }
  }
}

@DonNicoJs
Copy link
Contributor

I am marking this issue as a good hacktoberfest one, the goal here is to modify the file in integrations/github to add to the user repos both repo marked with language: 'vue' and with topics:
https://github.com/topics/vuejs
and
https://github.com/topics/vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request hacktoberfest newcomer-friendly
Projects
None yet
Development

No branches or pull requests

3 participants