Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui Improvement: Collect user discord tag #121

Closed
wants to merge 5 commits into from
Closed

Ui Improvement: Collect user discord tag #121

wants to merge 5 commits into from

Conversation

JoelLau
Copy link

@JoelLau JoelLau commented Oct 15, 2018

Attempt to resolve Issue #120

  • Modifycomponents/UserProfileForm.vue to collect the discordTag, right after the twitter profile
  • Modify components/PersonDetails.vue to display the discord icon (and link to discord profile ) after twitter icon on the top
  • Modify django/people/models.py to include discordTag as a field
  • Verify that everything works is and properly wired.

@DonNicoJs
Copy link
Contributor

@JoelLau Hi thank you for your PR!

Three things:

  • discord_tag is a simple string not an url, sorry maybe you were mislead by the twitter and github ones
  • Please create the migrations with docker-compose exec django python manage.py makemigrations ( after having adjusted the discord_tag name and type) and commit them
  • ( this is my mistake) since it's a tag and not an url it should not be near twitter or github in components/PersonDetails.vue but as another section under Organisation.

@JoelLau
Copy link
Author

JoelLau commented Oct 15, 2018

noted, I'm having some trouble with docker at the moment. gotta reinstall

@DonNicoJs
Copy link
Contributor

@JoelLau I have updated the contribution guide, you may want to take a look :)

@JoelLau
Copy link
Author

JoelLau commented Oct 16, 2018

urgh. having problems with docker on my windows machine ):

hope you don't mind me taking a few more hours to finish this

@DonNicoJs
Copy link
Contributor

@JoelLau no pressure! Quality over quantity :)

@DonNicoJs
Copy link
Contributor

@JoelLau do you plan to finish this pr ?

@JoelLau
Copy link
Author

JoelLau commented Oct 25, 2018

sorry, I couldn't get it to work ):

@DonNicoJs DonNicoJs closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants