Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some examples #228

Merged
merged 6 commits into from Mar 18, 2019
Merged

Add some examples #228

merged 6 commits into from Mar 18, 2019

Conversation

marcusklaas
Copy link
Collaborator

Addresses #105, #104, #15.

Fixes #209.

raphlinus
raphlinus approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Another thing I'd suggest (possibly as a separate PR) is fixing up the Cargo.toml metadata to point to the readme, so it renders in crates.io.

@marcusklaas
Copy link
Collaborator Author

Done!

@marcusklaas marcusklaas merged commit 52a032f into pulldown-cmark:master Mar 18, 2019
@marcusklaas marcusklaas deleted the examples branch March 18, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcusklaas @raphlinus @polyzen