Fix table/paragraph interruption when nested #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue pulldown-cmark#659 was closed via pulldown-cmark#668, so we can clean this up now.
There are small differences between how commonmark.js and pulldown-cmark emit these.
This fixes the "peek at next line" code to account for block quotes. It's a bit more complicated than just skipping ahead, because the old code would cause the block quote to get interrupted by a table nested inside it (it simulated reaching a blank line, which interrupts the block quote). Instead, this commit hooks into the normal paragraph-interrupt code.
…sue-659 Allow fuzzing all HTML declarations
Filter out empty text and HTML events when fuzzing
Block quotes interrupt paragraphs even with no space at start
…m/notriddle/pulldown-cmark into notriddle-notriddle/table-interrupt-nesting
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "peek at next line" code to account for block quotes. It's a bit more complicated than just skipping ahead, because the old code would cause the block quote to get interrupted by a table nested inside it (it simulated reaching a blank line, which interrupts the block quote). Instead, this commit hooks into the normal paragraph-interrupt code.